Urgent expansion of ARP garden approvers

[ameowlia]

Summary

The people maintaining garden do not have write access to garden repos. After months of work on garden, none are close to accumulating enough "points" to become an approver.

Problem

For months (a year?) Anthony Emengo singlehandedly maintained the garden codebase, even after it stopped being his full time job. Several months ago, he transferred the garden codebase and context to a new team within VMware. That new team (except for me as WG Tech Lead) does not have write permissions to garden. The old garden team members who are approvers are happy to help, but are no longer contributing to the project in any regular basis.

Until the spicy PR change, there were a few team members that had write access. Now I am the only one with access. Having me as a bottleneck has been inconvenient and slow, especially for CI work. I am going on break starting July 25. During my absence the team needs to be able to continue maintaining garden.

Solution

Add every new garden maintainer who has been working on Cloud Foundry for a minimum of 5 years to the garden approver list. Yes this is bypassing the official approver requirements, however it is still setting a very high standard for who is being added as an approver.

Proposed Garden Approvers

• Amin Jamali @aminjam
• Geoff Franks @geofffranks
• Josh Russet @jrussett
• Renee Chu @reneighbor
• Maria Shaldybin @mariash
• David Sabeti @dsabeti
• Marc Paquette @MarcPaquette

[ameowlia]

❓ Do I still need to change the cloudfoundry.yml, or does that happen programmatically?

[stephanme]

Changes to cloudfoundry.yml should not be needed anymore.

The github team https://github.com/orgs/cloudfoundry/teams/wg-app-runtime-platform-garden-containers-approvers is generated from the WG charter yaml section. Only if you still rely on non-standard github teams (e.g. for Concourse authorisation or branch protection rules) you need to maintain cloudfoundry.yml . But be aware of #262. I suggest to switch over to the standard, generated github teams.