Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate github teams according to RFC-0005 #310

Merged
merged 4 commits into from
Jun 21, 2022
Merged

Conversation

stephanme
Copy link
Contributor

  • teams for WG, WG areas, WG leads and WG bots
  • added empty bot user list to all WG yamls
  • enabled only for ARD and FI WGs as pilots

- teams for WG, WG areas, WG leads and WG bots
- added empty bot user list to all WG yamls
- enabled only for ARD and FI WGs as pilots
@stephanme stephanme requested review from rkoster and jochenehret June 15, 2022 11:41
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this script deal with repos outside the cloudfoundry org?

toc/working-groups/foundational-infrastructure.md Outdated Show resolved Hide resolved
stephanme and others added 2 commits June 15, 2022 18:37
Ignore all repos from other github orgs listed in WG yaml.
E.g. FI WG.

Fixed bot users in FI WG as all github users have name and github id
WG yaml (also bots).
@LeePorte LeePorte added the toc label Jun 21, 2022
TOC.md and WG md files which contain yaml blocks processed
by org-management.py
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it filters for repo's in the cloudfoundry org all my concerns are addressed.

maintainers = {u["github"] for u in wg["execution_leads"]}
maintainers |= {u["github"] for u in wg["technical_leads"]}
approvers = {u["github"] for a in wg["areas"] for u in a["approvers"]}
repositories = {r for a in wg["areas"] for r in a["repositories"] if r.startswith("cloudfoundry/")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to rework this line later when we onboard other orgs into the automation but for now it should be fine.

@emalm emalm self-requested a review June 21, 2022 14:44
@LeePorte LeePorte merged commit c90d32a into main Jun 21, 2022
@LeePorte LeePorte deleted the github-team-automation branch June 21, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants