Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC for approver requirements #244

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Apr 8, 2022

@ctlong ctlong closed this Apr 8, 2022
@ctlong ctlong deleted the rfc-approver-requirements branch April 8, 2022 22:15
@ctlong ctlong restored the rfc-approver-requirements branch April 8, 2022 22:15
@ctlong ctlong reopened this Apr 8, 2022
@rkoster rkoster self-requested a review April 12, 2022 14:51
@dsboulder
Copy link
Member

I'm happy with this! Please tag the other leads for feedback and start the 1 week review process.

The TOC requested that we add a description for technical discussions,
specifically calling out that they are counted per-thread rather than
per-message.
@ctlong
Copy link
Member Author

ctlong commented Apr 12, 2022

👋 Hi @jochenehret @Gerg @georgethebeatle @gcapizzi @beyhan @dmikusa-pivotal @ekcasey @ryanmoran @pivotal-marcela-campo @paulcwarren.

👀 This RFC will affect the conditions under which approvers are nominated to your WGs.

➡️ Could y'all please have a look through this document and let us know what you think.

@ctlong
Copy link
Member Author

ctlong commented Apr 12, 2022

This starts the 1 week review process 😁

@ryanmoran
Copy link
Contributor

I'm interested to hear what the TOC thinks about this PR and the broader ROLES document given the Paketo WGs "special status" as a separate project with its own governing structure. Do we need to have an explicit carveout for some of these specifications or is that covered elsewhere?

@jochenehret jochenehret self-requested a review April 13, 2022 07:36
Copy link
Contributor

@jochenehret jochenehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... not sure however how strictly we want to apply the "complete 20 of the following..." rule.

@ameowlia
Copy link
Member

ameowlia commented Apr 19, 2022

Hi @ryanmoran,

I'm interested to hear what the TOC thinks about this PR and the broader ROLES document given the Paketo WGs "special status" as a separate project with its own governing structure. Do we need to have an explicit carveout for some of these specifications or is that covered elsewhere?

The TOC chatted about this today. We decided not to make an explicit carveout for Paketo in this RFC. Paketo has its own governance, which we agreed is an implicit carveout for many things, including these approver requirements.

@emalm emalm self-requested a review April 20, 2022 19:47
@emalm
Copy link
Member

emalm commented Apr 20, 2022

This RFC now has unanimous approval from @cloudfoundry/toc and no outstanding discussion threads, so it is cleared to accept. I'll plan to merge it by the end of the week, unless another TOC member can take care of it first.

Note that acceptance of this RFC will then require a change to the ROLES.md document that describes the Approver criteria, which should come in a separate PR to be reviewed for consistency with this RFC's text.

@emalm emalm merged commit 34c7803 into cloudfoundry:main Apr 26, 2022
emalm added a commit that referenced this pull request Apr 26, 2022
@ctlong ctlong deleted the rfc-approver-requirements branch April 26, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.