-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RFC for approver requirements #244
Conversation
I'm happy with this! Please tag the other leads for feedback and start the 1 week review process. |
The TOC requested that we add a description for technical discussions, specifically calling out that they are counted per-thread rather than per-message.
👋 Hi @jochenehret @Gerg @georgethebeatle @gcapizzi @beyhan @dmikusa-pivotal @ekcasey @ryanmoran @pivotal-marcela-campo @paulcwarren. 👀 This RFC will affect the conditions under which approvers are nominated to your WGs. ➡️ Could y'all please have a look through this document and let us know what you think. |
This starts the 1 week review process 😁 |
I'm interested to hear what the TOC thinks about this PR and the broader ROLES document given the Paketo WGs "special status" as a separate project with its own governing structure. Do we need to have an explicit carveout for some of these specifications or is that covered elsewhere? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good... not sure however how strictly we want to apply the "complete 20 of the following..." rule.
Hi @ryanmoran,
The TOC chatted about this today. We decided not to make an explicit carveout for Paketo in this RFC. Paketo has its own governance, which we agreed is an implicit carveout for many things, including these approver requirements. |
This RFC now has unanimous approval from @cloudfoundry/toc and no outstanding discussion threads, so it is cleared to accept. I'll plan to merge it by the end of the week, unless another TOC member can take care of it first. Note that acceptance of this RFC will then require a change to the ROLES.md document that describes the Approver criteria, which should come in a separate PR to be reviewed for consistency with this RFC's text. |
cc @ameowlia