Max in flight #3907
Merged
Max in flight #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -218,6 +305,23 @@ module VCAP::CloudController | |||
| subject.scale | |||
| end.not_to(change(RouteMappingModel, :count)) | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| # when max_in_flight is greater than original_web_process_instance_count |
pivotalgeorge
suggested changes
Jul 30, 2024
pivotalgeorge
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
thanks for having a pair of pair of eyes on this with me @Samze !
Looks good to me with the deployment spec coverage
Samze
approved these changes
Jul 30, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jul 30, 2024
Changes in cloud_controller_ng:
- Max in flight
PR: cloudfoundry/cloud_controller_ng#3907
Author: Evan Farrar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* A short explanation of the proposed change:
** This exposes a new option for the deployment resource that
* An explanation of the use cases your change solves
** Currently, rolling deploys deploy one instance at a time, but if an app has many instances this can take quite a while
Links to any other associated PRs
** there is a CLI feature in progress, will link when it is a PR
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests