Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @sha256 part to the image path for Docker LRP rootfs #3889

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

pbusko
Copy link
Contributor

@pbusko pbusko commented Jul 17, 2024

  • A short explanation of the proposed change:

Fixes #3888

  • An explanation of the use cases your change solves

DockerURIConverter expected the @sha256 as part of the image path, not as part of the image tag. The change resulted in a broken rootfs docker uris.

  • Links to any other associated PRs

#3888

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@pbusko pbusko force-pushed the fix-docker-lrp-rootfs branch from b4fc636 to 6091a1a Compare July 17, 2024 13:50
@nicolasbender nicolasbender force-pushed the fix-docker-lrp-rootfs branch from 6091a1a to d9c8f99 Compare July 17, 2024 14:40
@pbusko pbusko changed the title Move @sha256 part to the image path for Docker LRP rootf Move @sha256 part to the image path for Docker LRP rootfs Jul 18, 2024
@johha johha merged commit e5fb425 into cloudfoundry:main Jul 18, 2024
8 checks passed
@johha johha deleted the fix-docker-lrp-rootfs branch July 18, 2024 07:36
@johha johha restored the fix-docker-lrp-rootfs branch July 18, 2024 07:36
@pbusko pbusko deleted the fix-docker-lrp-rootfs branch July 18, 2024 07:36
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Jul 18, 2024
Changes in cloud_controller_ng:

- Move @sha256 part to the image path for Docker LRP rootfs
    PR: cloudfoundry/cloud_controller_ng#3889
    Author: Pavel Busko <[email protected]>
    Author: Nicolas Bender <[email protected]>
sethboyles pushed a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPI 1.185.0 - Docker Push bug
3 participants