Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revision version to app logs #3885

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add revision version to app logs #3885

merged 1 commit into from
Jul 17, 2024

Conversation

sethboyles
Copy link
Member

@sethboyles sethboyles commented Jul 15, 2024

cloudfoundry/capi-release#442

See #3837 for more info

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

* Add new configuration to all job schemas that interact with diego.
* Even if the app has the revision feature disabled we still show the revision in
the logs if it has a revision associated with it.
@Samze Samze force-pushed the log_revision_id branch from 9f1f7c8 to feabab6 Compare July 16, 2024 15:13
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippthun philippthun merged commit 44d70c0 into main Jul 17, 2024
8 checks passed
@moleske moleske deleted the log_revision_id branch July 17, 2024 15:09
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Jul 17, 2024
Changes in cloud_controller_ng:

- Add revision version to app logs
    PR: cloudfoundry/cloud_controller_ng#3885
    Author: Seth Boyles <[email protected]>
    Author: Sam Gunaratne <[email protected]>
sethboyles added a commit that referenced this pull request Jul 23, 2024
* Add new configuration to all job schemas that interact with diego.
* Even if the app has the revision feature disabled we still show the revision in
the logs if it has a revision associated with it.

Co-authored-by: Sam Gunaratne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants