Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print output of blobstore benchmark again #3718

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

johha
Copy link
Contributor

@johha johha commented Apr 3, 2024

After enabling rubocop for rails the output of the blobstore benchmark is no longer shown. This change restores the previous puts for logging instead of Rails.logger.

Related commit: 796a574

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

After enabling rubocop for rails the output of the blobstore benchmark is no longer shown.
This change restores the previous `puts` for logging instead of `Rails.logger`.

Related commit: 796a574
@johha johha merged commit 23ac57c into main Apr 3, 2024
8 checks passed
@johha johha deleted the blob-benchmark-output branch April 3, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants