Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lock information logging to happen on info and to happen only once per state switch #3659

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Benjamintf1
Copy link
Member

@Benjamintf1 Benjamintf1 commented Feb 27, 2024

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

update lock information logging to happen on info and to happen only once per state switch

  • An explanation of the use cases your change solves:

makes lock information easier to find in logs, but less verbose so to be able to bring it to the info level

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@Benjamintf1
Copy link
Member Author

Would we want to keep these additional logs at a debug level, or remove all debug logs.

@philippthun
Copy link
Member

Would we want to keep these additional logs at a debug level, or remove all debug logs.

I don't think the debug logs are needed in addition.

@Benjamintf1
Copy link
Member Author

I just figured if you get one error, and a different error, it might be nice to see both if it's set to debug. Especially because I think saving the error off is going to lead to error spamming(I believe the errors have embeded timestamps). But I'm fine with just 1 log on both case.

@sethboyles
Copy link
Member

I agree that seeing more logs would be nice if you set to debug, but not sure how many operators would set to debug. I saw that is your call--I don't think its necessary, however.

@sethboyles sethboyles merged commit 8c9a212 into cloudfoundry:main Feb 28, 2024
8 checks passed
@Benjamintf1 Benjamintf1 deleted the update-logging-locks branch February 28, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants