Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set warning header for outdated CF CLIs #3657

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Set warning header for outdated CF CLIs #3657

merged 1 commit into from
Feb 28, 2024

Conversation

johha
Copy link
Contributor

@johha johha commented Feb 27, 2024

Introduces a new (optional) middleware which will warn CF CLI users if their version is below min_cli_version.
Needs to be explicitly enabled by setting the config flag warn_if_below_min_cli_version to true.

Capi-release PR to introduce new parameter: cloudfoundry/capi-release#388

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

middleware/below_min_cli_warning.rb Outdated Show resolved Hide resolved
middleware/below_min_cli_warning.rb Outdated Show resolved Hide resolved
spec/unit/lib/cloud_controller/rack_app_builder_spec.rb Outdated Show resolved Hide resolved
Introduces a new (optional) middleware which warns CF CLI users if their version is below `min_cli_version`.
Needs to be explicitly enabled by setting the config flag `warn_if_below_min_cli_version` to `true`.
@johha johha merged commit 4ed80dc into main Feb 28, 2024
8 checks passed
johha added a commit to cloudfoundry/capi-release that referenced this pull request Feb 28, 2024
@johha johha deleted the cli-warning branch February 28, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants