Change delayed_jobs_reserve index #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WHERE condition. Jobs that failed are only kept for debugging purposes, they are not taken into account when reserving a job. The corresponding SELECT statement [1] includes 'WHERE failed_at IS NULL', so the corresponding index can omit failed jobs. Partial indexes are not supported for MySQL, thus this change is only for PostgreSQL. [1] https://github.com/TalentBox/delayed_job_sequel/ blob/938ff68e98b44bbc391805c672a74c5ee3aef08b/ lib/delayed/backend/sequel.rb#L26
philippthun
force-pushed
the
change-delayed-jobs-reserve-index
branch
from
9cb7987 to
1077bae
Compare
johha
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
WHEREcondition. Jobs that failed are only kept for debugging purposes, they are not taken into account when reserving a job. The correspondingSELECTstatement [1] includesWHERE failed_at IS NULL, so the corresponding index can omit failed jobs.Partial indexes are not supported for MySQL, thus this change is only for PostgreSQL.
[1] https://github.com/TalentBox/delayed_job_sequel/blob/938ff68e98b44bbc391805c672a74c5ee3aef08b/lib/delayed/backend/sequel.rb#L26
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests