Introduce config option to disable statsd metrics #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathap
force-pushed
the
config-option-to-disable-statsd-metrics
branch
2 times, most recently
from
793c109 to
d956f6c
Compare
kathap
force-pushed
the
config-option-to-disable-statsd-metrics
branch
5 times, most recently
from
3cdfb20 to
42bd7ab
Compare
This config option allows to send metrics only via prometheus on api vms. The default is false. In the default case, metrics are sent via statsd and prometheus.
kathap
force-pushed
the
config-option-to-disable-statsd-metrics
branch
from
c8c728d to
8f8141b
Compare
…cause it is read in dependeny_locator and will error if the config parameter is not there. Defaults to false, so no effect for other than api vms.
|
What do you think about naming the config value |
philippthun
reviewed
Jan 18, 2024
philippthun
reviewed
Jan 18, 2024
kathap
force-pushed
the
config-option-to-disable-statsd-metrics
branch
from
4b05710 to
e72c874
Compare
kathap
force-pushed
the
config-option-to-disable-statsd-metrics
branch
from
e72c874 to
45ae830
Compare
philippthun
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config option allows to send metrics only via prometheus on api vms. The default is true (i.e. enabled). In the default case, metrics are sent via statsd and prometheus.
Links to any other associated PRs
Remove unused statsd clients #3526, Expose puma stats as prometheus metrics #3528, Adapt Periodic Puma Metrics #3521
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests