Enhance /v3/organizations/:guid/usage_summary #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathap
force-pushed
the
enhance_organizations_usage_summary
branch
4 times, most recently
from
4af54c2 to
aab84cb
Compare
philippthun
reviewed
Nov 30, 2023
spec/unit/lib/cloud_controller/organization_quota_usage_calculator_spec.rb
Outdated
Show resolved
Hide resolved
kathap
force-pushed
the
enhance_organizations_usage_summary
branch
from
5cfbc52 to
5f2829e
Compare
philippthun
reviewed
Dec 11, 2023
spec/unit/lib/cloud_controller/organization_quota_usage_spec.rb
Outdated
Show resolved
Hide resolved
It would be nice to get org usage info for (nearly) all resources that are restricted by an org quota plan, beside memory in mb and started instances, which are already implemented. In the course of the change running_and_pending_tasks_count was refactored from nested selects to joins. Joins are generally more efficient than nested selects, especially when dealing with large datasets. Co-authored-by: Philipp Thun <[email protected]>
kathap
force-pushed
the
enhance_organizations_usage_summary
branch
from
8317229 to
c70e1c5
Compare
a-b
approved these changes
Dec 13, 2023
…move total_ prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to get org usage info for (nearly) all resources that are restricted by an org quota plan, beside memory in mb and started instances, which are already implemented.
GET /v3/organizations/:guid/usage_summaryreturns now in addition tomemory_in_mbandstarted_instancesalso:routes,service_instances,reserved_ports,domains,per_app_tasks,service_keysWith this change it is possible to get org usage info for all resources that are restricted by an org quota plan.
log_rate_limit_in_bytes_per_secondwill be skipped for now, as it would introduce a dependency to diego.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests