Readiness health checks story 6 rolling deploys #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActualLRP has routable set to true once readiness health check succeeds. In case if routable is not provided instance reporter sets it to true for backwards compatibility. Signed-off-by: Josh Russett <[email protected]>
mariash
force-pushed
the
readiness-health-checks-story-6-rolling
branch
from
17dba77 to
72ae081
Compare
sethboyles
approved these changes
Aug 10, 2023
moleske
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Add readiness health check properties to app manifest * Set readiness health check properties on process Now when a user supplies the readiness health check properties via the app manifest, the values are stored on the process, and saved in the database. * correctly default to process for readiness_health_check_type * Refactor: add base health check policy class * Set readiness health check properties on LRP * Refactor: app recipe builder now with more ruby style! * Fix: readiness hcs default to process not empty * Add readiness health check properties to /v3/apps/:guid/manifest * Return diff for readiness check properties in /v3/spaces/:space_guid/manifest_diff * Readiness health checks story 5 processes (#3370) * Add readiness health check properties to process endpoints GET /v3/processes GET /v3/processes/:guid PATCH /v3/processes/:guid GET /v3/apps/:guid/processes GET /v3/apps/:guid/processes/:type PATCH /v3/apps/:guid/processes/:type POST /v3/apps/:guid/processes/:type/actions/scale * Add readiness health check examples to API docs * Rolling deploy respects readiness health check (#3373) ActualLRP has routable set to true once readiness health check succeeds. In case if routable is not provided instance reporter sets it to true for backwards compatibility. * Readiness health checks story 7 respect defined interval (#3385) * Validate health_check_interval/readiness_health_check_interval in the manifest * Save health_check_interval/readiness_health_check_interval in database * Regenerate bbs protobuf models * Pass health_check_interval/readiness_health_check_interval in LRP * Display health_check_interval/readiness_health_check_interval in manifest * Add health-check-interval/readiness-health-check-interval to manifest diff * Add health-check-interval/readiness-health-check-interval to manifest docs * Add health_check_interval/readiness_health_check_interval to /v3/processes * Add health_check_interval/readiness_health_check_interval to API docs * Copy health_check_interval/readiness_health_check_interval during rolling deploy * add need readiness check doc to index * Disable rubocop cyclomaticcomplexity for some functions - these functions are idomatic ruby with no nested if statements - rubocop is just counting if statements so no current concerns - please review if this changes * Do not use text:true on readiness health check to process - see https://github.com/cloudfoundry/cloud_controller_ng/wiki/CAPI-Migration-Style-Guide#always-specify-a-size-for-a-string-and-dont-use-text Signed-off-by: Marc Paquette <[email protected]> Signed-off-by: Amelia Downs <[email protected]> Signed-off-by: Renee Chu <[email protected]> Signed-off-by: Maria Shaldybin <[email protected]> Signed-off-by: Josh Russett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a larger effort detailed here in this Cloud Controller PR and here in this CFF RFC.
In this story
routableparameter. Diego sets it to true when readiness health checks are not provided or set toprocess.routableis not provided in ActualLRP protobuf message Diego instance reporter sets it to true for backwards compatibility.GET /v2/apps/:guid/instancesto includeroutableparameter since the controller for this endpoint is using the same method all_instances_for_app that is used in deployment updater.Acceptance Setup
cf push --strategy=rollingthat has eventually successful readiness check. In parallel window see that curling application does not fail.cf push --strategy=rollingwith failing readiness check. New application should return different response. See that new code is not being deployed and curling application does not fail.cf push --strategy=rollingthat that does not have readiness check. See that application is updated and curling application does not fail.