Readiness health checks story 4 manifest endpoints #3368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a larger effort detailed here in this Cloud Controller PR and here in this CFF RFC.
In this story
/v3/apps/:guid/manifest
endpoint to include example of readiness health check properties.cf create-app-manifest
returns readiness health check properties in the generated manifest as a result of the above changecf push
properly displays the diff for updates. /v3/spaces/:space_guid/manifest_diff was changed to return diff for readiness health check properties.Please note:
health-check-invocation-timeout
property was not exposed before. Please let us know if this was done intentionally. It was added to be consistent withreadiness-health-check-invocation-timeout
.Acceptance Setup
cf curl /v3/apps/:guid/manifest
should returnreadiness-health-check-type: process
cf create-app-manifest app-name
should generate manifest withreadiness-health-check-type: process
cf curl /v3/apps/:guid/manifest
should return these propertiescf create-app-manifest app-name
should return these properties