Add partial search by usernames to GET /organizations/:guid/users #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For partial_usernames parameter we are using UAA /Users endpoint that require `scim.read` scope. This change is reflected in CF-D [PR](cloudfoundry/cf-deployment#984) Co-authored-by: Juan Diego Gonzalez <[email protected]> Co-authored-by: Alexander Berezovsky <[email protected]>
philippthun
reviewed
Aug 11, 2022
| if precise_username_match | ||
| results = query(:user_id, includeInactive: true, filter: filter_string) | ||
| else | ||
| results = query(:user, filter: filter_string, attributes: 'id') |
There was a problem hiding this comment.
So for partial usernames, only active ones will be returned, right?
| expect(message.partial_usernames).to eq(%w[bob]) | ||
| end | ||
| end | ||
|
|
||
| context 'guids, usernames, origins are nil' do | ||
| let(:params) do | ||
| { |
There was a problem hiding this comment.
The context 'guids, usernames, origins must be arrays' should not be underneath context 'guids, usernames, origins are nil'.
philippthun
reviewed
Aug 11, 2022
philippthun
reviewed
Aug 11, 2022
10 tasks
pivotalgeorge
force-pushed
the
feature/users-partial-search
branch
from
a8c4168 to
ec28a76
Compare
a-b
force-pushed
the
feature/users-partial-search
branch
from
ec28a76 to
92242e8
Compare
dalvarado
reviewed
Aug 16, 2022
There was a problem hiding this comment.
Looks good to @MerricdeLauney and me. We'll merge once you finalize the open discussions with Philip.
moleske
reviewed
Aug 16, 2022
jdgonzaleza
force-pushed
the
feature/users-partial-search
branch
from
92242e8 to
51fbbc4
Compare
|
@jdgonzaleza I think you deleted most of the |
Co-authored-by: Juan Diego Gonzalez <[email protected]> Co-authored-by: Alexander Berezovsky <[email protected]>
jdgonzaleza
force-pushed
the
feature/users-partial-search
branch
from
51fbbc4 to
4580e86
Compare
philippthun
approved these changes
Aug 17, 2022
|
Are there any other pending implementation issues blocking us from merging this PR? |
a-b
requested review from
dalvarado,
jdgonzaleza and
moleske
and removed request for
ctlong
pivotalgeorge
approved these changes
Aug 25, 2022
a-b
requested review from
jdgonzaleza
and removed request for
MerricdeLauney and
jdgonzaleza
fhambrec
pushed a commit
to ZPascal/cloud_controller_ng
that referenced
this pull request
Oct 20, 2022
…oudfoundry#2920) * Add partial search by usernames to GET /organizations/:guid/users For partial_usernames parameter we are using UAA /Users endpoint that require `scim.read` scope. This change is reflected in CF-D [PR](cloudfoundry/cf-deployment#984) Co-authored-by: Alexander Berezovsky <[email protected]> Co-authored-by: Juan Diego Gonzalez <[email protected]>
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
…oudfoundry#2920) * Add partial search by usernames to GET /organizations/:guid/users For partial_usernames parameter we are using UAA /Users endpoint that require `scim.read` scope. This change is reflected in CF-D [PR](cloudfoundry/cf-deployment#984) Co-authored-by: Alexander Berezovsky <[email protected]> Co-authored-by: Juan Diego Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Add partial search by usernames to GET /organizations/:guid/users
For partial_usernames parameter, we are using UAA /Users endpoint that requires
scim.readscope.An explanation of the use cases your change solves
This will let us to find usernames by substring e.g.
GET /organizations/:guid/users?partial_usernames=fooLinks to any other associated PRs
CF-D PR
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests
Coauthored by @jdgonzaleza