Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass based on the equivalent BOSH PR. CC uses a
runner.rb
rather than embedding the server startup directly in thebin/
script so move stuff there.Still needs a lot of work:
thread_info
(EM) metricspreload_app!
? - we don't really need fast startup time for workers as we probably won't cycle them and it means we have to disconnect the DB after loading the models. It might be simpler to just start the CC after forking which should hopefully mean the DB only connects after forkingHopefully this helps at least have a play around with it. I'm pretty stuck on what to do about metrics - maybe try and uniquely identify a worker and put that identifier in the metric? We use Telegraf for collecting our StatsD metrics which supports tagging but not every StatsD implementation does so that may not be a great option.
cc: @sethboyles