Send provider in gateway provision request (with bump to vcap-common) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2013 11:51
- Bump vcap-common (required for updated gateway provision request)
git shortlog b9024a52..055964f622
Dr Nic Williams (1):
VCAP::Component.register returns its configuration
Harshawardhan Gadgil (1):
Add (optional) user guid and space guid to gateway provision request
Change-Id: I3ad8827c9d5ef0e017fde34d58c2baf10ee8ac21
- git shortlog 055964f622..9267b079b1
Harshawardhan Gadgil (1):
Add (optional) provider to GatewayProvisionRequest
Change-Id: I2aba012badd16bc1a81c1598f65d041e94b38da3
5 tasks
MerricdeLauney
added a commit
that referenced
this pull request
May 3, 2022
Notable changes in this commit: * Adds an `/internal/v4/metrics` endpoint which serves Prometheus-style metrics. * Adds function to Prometheus::Client::Registry to re-create the library's metrics registry. This is used by the PrometheusClient class's tests to wipe out the metrics registry, which is global state. Global state is the #1 cause of test pollution and this change seemed to be the most straightforward way to eliminate some order-dependent test failures. NOTE: This function definition is only in the `prometheus_updater_spec.rb` file, which we believe is not shipped in capi-release, so the odds of actually writing production code that depends on this test-only functionality are pretty slim. Co-authored-by: David Alvarado <[email protected]> Co-authored-by: Kenneth Lakin <[email protected]> Co-authored-by: Merric de Launey <[email protected]> Co-authored-by: Michael Oleske <[email protected]>
MerricdeLauney
added a commit
that referenced
this pull request
May 31, 2022
Notable changes in this commit: * Adds an `/internal/v4/metrics` endpoint which serves Prometheus-style metrics. * Adds function to Prometheus::Client::Registry to re-create the library's metrics registry. This is used by the PrometheusClient class's tests to wipe out the metrics registry, which is global state. Global state is the #1 cause of test pollution and this change seemed to be the most straightforward way to eliminate some order-dependent test failures. NOTE: This function definition is only in the `prometheus_updater_spec.rb` file, which we believe is not shipped in capi-release, so the odds of actually writing production code that depends on this test-only functionality are pretty slim. Co-authored-by: David Alvarado <[email protected]> Co-authored-by: Kenneth Lakin <[email protected]> Co-authored-by: Merric de Launey <[email protected]> Co-authored-by: Michael Oleske <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes verified on dev104 env.