cleanup: rename list of health check types

split out readiness health check types into its own method
cloudfoundry · Jul 27, 2023 · 2cfe394 · 2cfe394
1 parent 0dbbb06
commit 2cfe394
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/app/models/helpers/health_check_types.rb b/app/models/helpers/health_check_types.rb
@@ -5,13 +5,17 @@ class HealthCheckTypes
     HTTP = 'http'.freeze
     NONE = 'none'.freeze
 
-    def self.constants_to_array
+    def self.all_types
       [
         HTTP,
         NONE,
         PORT,
         PROCESS,
       ]
     end
+
+    def self.readiness_types
+      self.all_types - [NONE]
+    end
   end
 end
diff --git a/app/models/runtime/constraints/health_check_policy.rb b/app/models/runtime/constraints/health_check_policy.rb
@@ -9,7 +9,7 @@ def initialize(process, health_check_timeout, health_check_invocation_timeout, h
     @health_check_invocation_timeout = health_check_invocation_timeout
     @health_check_type = health_check_type
     @health_check_http_endpoint = health_check_http_endpoint
-    @valid_health_check_types = VCAP::CloudController::HealthCheckTypes.constants_to_array
+    @valid_health_check_types = VCAP::CloudController::HealthCheckTypes.all_types
     @var_to_symbol = {
       'timeout' => :health_check_timeout,
       'type' => :health_check_type,

diff --git a/app/models/runtime/constraints/readiness_health_check_policy.rb b/app/models/runtime/constraints/readiness_health_check_policy.rb
@@ -1,7 +1,7 @@
 class ReadinessHealthCheckPolicy < HealthCheckPolicy
   def initialize(process, health_check_invocation_timeout, health_check_type, health_check_http_endpoint)
     super(process, nil, health_check_invocation_timeout, health_check_type, health_check_http_endpoint)
-    @valid_health_check_types = VCAP::CloudController::HealthCheckTypes.constants_to_array - [VCAP::CloudController::HealthCheckTypes::NONE]
+    @valid_health_check_types = VCAP::CloudController::HealthCheckTypes.readiness_types
     @var_to_symbol = {
       'type' => :readiness_health_check_type,
       'invocation_timeout' => :readiness_health_check_invocation_timeout,