fix: log more details when setting up DB connection #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently had to debug a situation where setting up the DB connection failed. We found this difficult because the logs were quite sparse in what they recorded. This change adds username and TLS string to the log, both of which should not contain secrets.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/181713675 The labels on this github issue will be updated when the story is started. |
FelisiaM
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had to debug a situation where setting up the DB connection
failed. We found this difficult because the logs were quite sparse in
what they recorded. This change adds username and TLS string to the log,
both of which should not contain secrets.
Checklist:
[ ] Have you added or updated tests to validate the changed functionality?docs/draft-release-notes.md?