feat: add --wait flag to upgrade-service #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the service commands (e.g. "cf update-service") take a --wait flag to wait for completion. For some reason "cf upgrade-service" did not, and this commit resolves that inconsistency.
jdgonzaleza
added a commit
that referenced
this pull request
Sep 14, 2022
This reverts commit 41ebecb.
jdgonzaleza
added a commit
that referenced
this pull request
Sep 14, 2022
blgm
added a commit
to blgm/cli
that referenced
this pull request
Apr 12, 2023
Most of the service commands (e.g. "cf update-service") take a --wait flag to wait for completion. For some reason "cf upgrade-service" did not, and this commit resolves that inconsistency. This is a redone version of cloudfoundry#2285 which was reverted in cloudfoundry#2317
blgm
added a commit
to blgm/cli
that referenced
this pull request
Apr 20, 2023
Most of the service commands (e.g. "cf update-service") take a --wait flag to wait for completion. For some reason "cf upgrade-service" did not, and this commit resolves that inconsistency. This is a redone version of cloudfoundry#2285 which was reverted in cloudfoundry#2317
blgm
added a commit
to blgm/cli
that referenced
this pull request
Apr 20, 2023
Most of the service commands (e.g. "cf update-service") take a --wait flag to wait for completion. For some reason "cf upgrade-service" did not, and this commit resolves that inconsistency. This is a redone version of cloudfoundry#2285 which was reverted in cloudfoundry#2317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6, CLI v7, or CLI v8?
This PR is aimed for vNext (v9), but could be cherry-picked to v8 if that was considered appropriate.
Description of the Change
Most of the service commands (e.g. "cf update-service") take a --wait
flag to wait for completion. For some reason "cf upgrade-service" did
not, and this commit resolves that inconsistency.
Why Is This PR Valuable?
It makes the service commands more usable and more consistent
Why Should This Be In Core?
It's a modification to a core command
Applicable Issues
None
How Urgent Is The Change?
Not urgent at all
Other Relevant Parties
Who else is affected by the change?
No-one