Skip to content

Commit

Permalink
v8(services): delete service better confirmation message (#2115)
Browse files Browse the repository at this point in the history
In common with other V3 endpoints, the intention is for deleting a
service to be recursive. The confirmation message in the CLI should
reflect this.

[#175741832](https://www.pivotaltracker.com/story/show/175741832)
  • Loading branch information
blgm authored Nov 20, 2020
1 parent b823ae5 commit a09fdf3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion command/v7/delete_service_command.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func (cmd DeleteServiceCommand) displayEvent() error {
func (cmd DeleteServiceCommand) displayPrompt() (bool, error) {
delete, err := cmd.UI.DisplayBoolPrompt(
false,
"Really delete the service instance {{.ServiceInstanceName}}?",
"Really delete the service instance {{.ServiceInstanceName}}, including app bindings, route bindings, and service keys?",
cmd.serviceInstanceName(),
)
if err != nil {
Expand Down
5 changes: 3 additions & 2 deletions command/v7/delete_service_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,9 @@ var _ = Describe("delete-service command", func() {
})

It("prompts the user", func() {
Expect(testUI.Out).To(SatisfyAll(
Say(`Really delete the service instance %s\? \[yN\]:`, serviceInstanceName),
Expect(testUI.Out).To(Say(
`Really delete the service instance %s, including app bindings, route bindings, and service keys\? \[yN\]:`,
serviceInstanceName,
))
})

Expand Down

0 comments on commit a09fdf3

Please sign in to comment.