Skip to content

Commit

Permalink
Use default of 1GB memory instead of 32M
Browse files Browse the repository at this point in the history
- a regular deploy of cf-deployment has a default memory limit of 1G
- if we prefer to use 32M, we should change the tests to push an app specifying that as the limit instead
  • Loading branch information
moleske authored and a-b committed Oct 21, 2022
1 parent 4b0fcc0 commit 711a346
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions integration/v7/isolated/scale_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ var _ = Describe("scale command", func() {
helpers.WithProcfileApp(func(appDir string) {
Eventually(helpers.CustomCF(helpers.CFEnv{WorkingDirectory: appDir}, "push", appName)).Should(Exit(0))
})
helpers.WaitForAppMemoryToTakeEffect(appName, 0, 0, false, "32M")
helpers.WaitForAppMemoryToTakeEffect(appName, 0, 0, false, "1G")
})

When("scale option flags are not provided", func() {
Expand Down Expand Up @@ -161,7 +161,7 @@ var _ = Describe("scale command", func() {
Consistently(session).ShouldNot(Say("Stopping"))
Consistently(session).ShouldNot(Say("Starting"))

helpers.WaitForAppMemoryToTakeEffect(appName, 0, 0, true, "32M")
helpers.WaitForAppMemoryToTakeEffect(appName, 0, 0, true, "1G")

session = helpers.CF("app", appName)
Eventually(session).Should(Exit(0))
Expand Down
2 changes: 1 addition & 1 deletion integration/v7/isolated/start_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ var _ = Describe("start command", func() {
Eventually(session).Should(Say(`routes:\s+%s.%s`, appName, helpers.DefaultSharedDomain()))
Eventually(session).Should(Say(`type:\s+web`))
Eventually(session).Should(Say(`instances:\s+1/1`))
Eventually(session).Should(Say(`memory usage:\s+32M`))
Eventually(session).Should(Say(`memory usage:\s+1024M`))
Eventually(session).Should(Say(`\s+state\s+since\s+cpu\s+memory\s+disk\s+logging\s+details`))
Eventually(session).Should(Say(`#0\s+(starting|running)\s+\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z`))

Expand Down

0 comments on commit 711a346

Please sign in to comment.