Skip to content

Commit

Permalink
v8(services): enable binding parameters test
Browse files Browse the repository at this point in the history
The issue that blocked this has now been resolved

[#175573217](https://www.pivotaltracker.com/story/show/175573217)
  • Loading branch information
blgm committed Jan 21, 2021
1 parent daa64ed commit 4cf0e1e
Showing 1 changed file with 13 additions and 18 deletions.
31 changes: 13 additions & 18 deletions integration/v7/isolated/bind_service_command_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,24 +207,19 @@ var _ = Describe("bind-service command", func() {
Expect(binding.LastOperation.State).To(BeEquivalentTo("succeeded"))
})

// --------------------------------------------------------------------------------------
// Will not work until this is fixed: https://www.pivotaltracker.com/story/show/175515392
// --------------------------------------------------------------------------------------
//
//When("parameters are specified", func() {
// It("fails with an error returned by the CC", func() {
// session := helpers.CF(command, appName, serviceInstanceName, "-c", `{"foo":"bar"}`)
// Eventually(session).Should(Exit(1))
//
// Expect(session.Out).To(SatisfyAll(
// Say(`Binding service instance %s to app %s in org %s / space %s as %s\.\.\.\n`, serviceInstanceName, appName, orgName, spaceName, username),
// Say(`\n`),
// Say(`FAILED\n`),
// ))
//
// Expect(session.Err).To(Say(`Binding parameters are not supported for user-provided service instances\n`))
// })
//})
When("parameters are specified", func() {
It("fails with an error returned by the CC", func() {
session := helpers.CF(command, appName, serviceInstanceName, "-c", `{"foo":"bar"}`)
Eventually(session).Should(Exit(1))

Expect(session.Out).To(SatisfyAll(
Say(`Binding service instance %s to app %s in org %s / space %s as %s\.\.\.\n`, serviceInstanceName, appName, orgName, spaceName, username),
Say(`FAILED\n`),
))

Expect(session.Err).To(Say(`Binding parameters are not supported for user-provided service instances\n`))
})
})
})

Context("managed service instance with synchronous broker response", func() {
Expand Down

0 comments on commit 4cf0e1e

Please sign in to comment.