Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added required_user_groups for client get, add and update #127

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Added required_user_groups for client get, add and update #127

merged 1 commit into from
Nov 21, 2023

Conversation

cache-sk
Copy link
Contributor

Feature requested in #126

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@strehle strehle self-assigned this Nov 16, 2023
@strehle strehle linked an issue Nov 16, 2023 that may be closed by this pull request
Missing parameter required_user_groups for client #126
Closed
hsinn0
hsinn0 reviewed Nov 18, 2023
View reviewed changes
Copy link
Contributor

@hsinn0 hsinn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cache-sk, thanks for the PR submission. I wonder if you can add test case(s) for this feature. See spec/client_reg_spec.rb for existing examples.

@strehle strehle mentioned this pull request Nov 18, 2023
Merged
strehle
strehle approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@strehle strehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests in #129

@strehle strehle mentioned this pull request Nov 18, 2023
Closed
@strehle strehle merged commit 4736244 into cloudfoundry:main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsinn0 hsinn0 hsinn0 approved these changes

@strehle strehle strehle approved these changes

Assignees

@strehle strehle

Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing parameter required_user_groups for client
4 participants
@cache-sk @cf-gitbot @strehle @hsinn0