Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github action to run the ginkgo tests on each PR #51

Closed
wants to merge 5 commits into from

Conversation

garethjevans
Copy link
Contributor

Depends on #50

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/180206525

The labels on this github issue will be updated when the story is started.

Copy link
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinJCross
Copy link

@ctlong would you mind merging this for @garethjevans ?
Ive got another PR for ginkgo v2 (and slight improvements) I'd like to create but I based it off @garethjevans fork.

@ctlong
Copy link
Member

ctlong commented May 18, 2022

@KevinJCross I would not advise basing your PR off of this branch. The go mod changes here were superseded by #54, which I imagine is what you care about.

@ctlong
Copy link
Member

ctlong commented Jun 7, 2022

Closing for lack of activity

@ctlong ctlong closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants