Mask off non-permission parts of unix file mode for resource match #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schulzh
force-pushed
the
fix-resource-match-permissions
branch
2 times, most recently
from
da15114 to
b5c165e
Compare
schulzh
force-pushed
the
fix-resource-match-permissions
branch
from
b5c165e to
394060b
Compare
|
Change looks good to me. I would expect the permission to be encoded in short POSIX format anyways. |
|
@anthonydahanne, @pivotal-david-osullivan thanks for looking into this in #1216. To my understanding this can be closed now because it is applied via #1216 or? |
|
Closing as work integrated via #1216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting the resource match API during pushing of an application, the cloud controller now expects only the permissions part of the file mode to be sent. This change masks off the other part (file type) to restore compatibility.
See cloudfoundry/cloud_controller_ng#3329 for more details.