Update workstation scripts to be more broadly useful #64

Gerg · 2024-05-22T18:51:51Z

- It is no longer needed by capi-ci, since removing Slack integration from the bosh-lite pool. - It will be less lonely here, since this is where the rest of the bosh-lite pool scripts live.

- Remove dependency on git-together - Remove dependency on direnv - Remove dependency on lastpass CLI - Remove Pivotal Tracker integration - No longer prompts for Pivotal Tracker story id - Adds Jira integration (not really; just kidding) - No longer changes your working directory - Fix hostname for zsh (no $HOSTNAME environment variable)

- Mostly just adding some stdout lines to clarify what the command is doing

- Remove dependency on git-together - Unset more environment variables - Fix hostname for zsh (no $HOSTNAME environment variable)

- cause not everyone uses aliases

- Remove story column - Remove staleness. Bosh lites are eternally fresh! - Gracefully handle case when no environment are claimed. Previously this would would trigger an "ambiguous ref" error from git, due to weirdness when globbing empty directories.

- No longer used - Depends the dead canibump app (RIP)

- Per CredHub CLI output: Login ignored as the CREDHUB_* environment variables are present. You do NOT need to run this "login" command in order to run other "credhub" commands when you set the CREDHUB_* environment variables. The command only validates your credentials. For backwards compatibility reasons, it (in this particular use case) does not error out. You should not use it with the environment variables set. The "credhub login" command is useful in the case you do not have the environment variables set and you pass your credentials to "credhub login" through command line arguments. - Add some guards for commands that require a targeted bosh. For instance, if they require credhub env vars to be set =)

- Remove the `set_capi_*_pipeline` scripts. They didn't do that much and have some baked-in assumptions (e.g. having a fly target named "capi"). They didn't seem worth parameterizing to make them more portable, but we can do it if people care enough. - Remove `gcs_to_claimed` script. I'm not really sure what this did, but it doesn't seem to be widely used, and it's not very portable. It also duplicates some of the behavior in `claim_bosh_lite`, which I'd rather not have to maintain independently.

- Add additional stoutput to help explain what is going on - Add guards to make sure there is an environment targeted - Reincarnate `use-created-capi.yml` ops file, formerly of capi-ci, but now gone. This ops file is used to build and deploy a capi release from your local filesystem, thanks to bosh handling local file urls. - Loosen assumptions about local directory structure. The commands now let you provide environment variables to override the default assumption that you have a relevant repos in a `~/workspace` directory. - Miscellaneous other small style changes, because I can

- Soften more directory structure opinions - Change some output formatting to be more consistent with other commands - Remove indenting output by piping to sed, since it doesn't work for non-stdout terminal output (e.g. bosh CLI output is often not pipe-able)

- Most CAPI work is tracked via GitHub issues now; Tracker is not used by most/all CAPI contributors. - Story is no longer needed for claiming bosh lites (via prior commit)

- Take org/space name as arguments, akin to bootstrap_cf - Change default names to "org" and "space", instead of "test", so that they match bootstrap_cf

- Does not work; It attempted to call bin/staged_shortlog, which doesn't exist. - The actual staged_shortlog is in capi-release/scripts

- The script assumed that it was inside capi-release's scripts directory. It was not.

- Consistent with removing other minor concourse-related scripts (see previous commit) - Provides dubious value vs using fly yourself, and it has a hard-coded target name

- Part of larger effort to remove lastpass dependency - Most CAPI contributors don't use lastpass anymore

- Add some missing scripts

moleske

I haven't tested every command in this pr, but it seems reasonable to me. Are you waiting for something in particular to change this to not a draft and get back to the main branch?

- Move heavy-weight installation instructions to the bottom, since they are not in common use - Emphasize the light-weight installation instructions (adding scripts to path and sourcing functions) - Add section espousing the wonders of the bosh lite pool - Remove some "Pivotal" references

Gerg · 2024-06-12T00:28:57Z

I haven't tested every command in this pr, but it seems reasonable to me. Are you waiting for something in particular to change this to not a draft and get back to the main branch?

I had a secret list of things I wanted to do, which I have now more-or-less accomplished. I converted to a full PR.

- Remove most opinions about development environment (vim, ruby dev, git, GOPATH, etc) - Limit to dev-machine-agnostic functions for CAPI development

evanfarrar

Found a typo in the readme, but otherwise LGTM

evanfarrar · 2024-06-24T20:43:44Z

README.md

+As a perk, [CAPI
+approvers](https://github.com/cloudfoundry/community/blob/main/toc/working-groups/app-runtime-interfaces.md)
+get access to a pool of cf-deployment environments, deployed on bosh lites in a
+CFF-managed IaaS account. These environments are displosable, and are only


s/displosable/disposable/

tcdowney

thx

moleske

whoopsie doodle, didn't realize making a commit to fix the spelling error would dismiss a perfectly cromulent review. apologies tim

tcdowney

Looks even better to me!

Gerg added 2 commits May 20, 2024 16:54

Import print_env_info script from capi-ci

e7bd827

- It is no longer needed by capi-ci, since removing Slack integration from the bosh-lite pool. - It will be less lonely here, since this is where the rest of the bosh-lite pool scripts live.

Gerg force-pushed the ari-bosh-lite-pool-reform branch from 96af36b to e884357 Compare May 23, 2024 00:37

Gerg added 2 commits May 23, 2024 14:21

Tidy up target_bosh function

41e3d27

- Mostly just adding some stdout lines to clarify what the command is doing

Tidy unclaim_bosh_lite function

0babee8

- Remove dependency on git-together - Unset more environment variables - Fix hostname for zsh (no $HOSTNAME environment variable)

Gerg requested review from sethboyles, tcdowney and moleske May 24, 2024 20:40

moleske and others added 12 commits May 24, 2024 15:33

Use git commit instead of git ci

3fe03bf

- cause not everyone uses aliases

Simplify print_env_info

18e8aad

- Remove story column - Remove staleness. Bosh lites are eternally fresh! - Gracefully handle case when no environment are claimed. Previously this would would trigger an "ambiguous ref" error from git, due to weirdness when globbing empty directories.

Delete can-i-push

95c77bc

- No longer used - Depends the dead canibump app (RIP)

Unclaim also unsets CREDHUB_CA_CERT env var

dd7c940

Add shebang to bin/fixcommitter

3e7e693

Additional minor tidying

440a0fc

- Soften more directory structure opinions - Change some output formatting to be more consistent with other commands - Remove indenting output by piping to sed, since it doesn't work for non-stdout terminal output (e.g. bosh CLI output is often not pipe-able)

Remove bin/story

e94f245

- Most CAPI work is tracked via GitHub issues now; Tracker is not used by most/all CAPI contributors. - Story is no longer needed for claiming bosh lites (via prior commit)

Tidy seed_users

5629be8

- Take org/space name as arguments, akin to bootstrap_cf - Change default names to "org" and "space", instead of "test", so that they match bootstrap_cf

Remove commit_with_shortlog

4d78f00

- Does not work; It attempted to call bin/staged_shortlog, which doesn't exist. - The actual staged_shortlog is in capi-release/scripts

Gerg force-pushed the ari-bosh-lite-pool-reform branch from 64acd70 to 4d78f00 Compare June 5, 2024 23:45

Gerg added 5 commits June 5, 2024 16:48

Fix run_bridge_tests

456eb81

- The script assumed that it was inside capi-release's scripts directory. It was not.

Remove watch_cc_units

33dec69

- Consistent with removing other minor concourse-related scripts (see previous commit) - Provides dubious value vs using fly yourself, and it has a hard-coded target name

Remove bin/load-key

a283c1a

- Part of larger effort to remove lastpass dependency - Most CAPI contributors don't use lastpass anymore

Remove bin/pivotal_login

2c2965c

Update capidoc with recent changes

2e858f3

- Add some missing scripts

moleske reviewed Jun 9, 2024

View reviewed changes

Gerg added 2 commits June 11, 2024 17:21

Small UI improvements to scripts

a7e3645

Gerg force-pushed the ari-bosh-lite-pool-reform branch from fc9bd7c to 811d1c3 Compare June 12, 2024 00:26

Gerg marked this pull request as ready for review June 12, 2024 00:27

Gerg requested review from stephanme and johha June 12, 2024 16:18

Purge lib directory

a6cbfa1

- Remove most opinions about development environment (vim, ruby dev, git, GOPATH, etc) - Limit to dev-machine-agnostic functions for CAPI development

Gerg requested a review from evanfarrar June 24, 2024 20:37

evanfarrar approved these changes Jun 24, 2024

View reviewed changes

tcdowney previously approved these changes Jun 24, 2024

View reviewed changes

Fix spelling

4f2f068

moleske dismissed tcdowney’s stale review via 4f2f068 June 25, 2024 03:14

moleske approved these changes Jun 25, 2024

View reviewed changes

tcdowney approved these changes Jun 25, 2024

View reviewed changes

moleske merged commit 66c13c7 into main Jun 25, 2024
1 check passed

moleske deleted the ari-bosh-lite-pool-reform branch June 25, 2024 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update workstation scripts to be more broadly useful #64

Update workstation scripts to be more broadly useful #64

Gerg commented May 22, 2024 •

edited

Loading

moleske left a comment

Gerg commented Jun 12, 2024 •

edited

Loading

evanfarrar left a comment

evanfarrar Jun 24, 2024

tcdowney left a comment

moleske left a comment

tcdowney left a comment

Update workstation scripts to be more broadly useful #64

Update workstation scripts to be more broadly useful #64

Conversation

Gerg commented May 22, 2024 • edited Loading

moleske left a comment

Choose a reason for hiding this comment

Gerg commented Jun 12, 2024 • edited Loading

evanfarrar left a comment

Choose a reason for hiding this comment

evanfarrar Jun 24, 2024

Choose a reason for hiding this comment

tcdowney left a comment

Choose a reason for hiding this comment

moleske left a comment

Choose a reason for hiding this comment

tcdowney left a comment

Choose a reason for hiding this comment

Gerg commented May 22, 2024 •

edited

Loading

Gerg commented Jun 12, 2024 •

edited

Loading