Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging Rate Limits - Allow operators to better control log production #245

Closed
klakin-pivotal opened this issue Jun 7, 2022 · 6 comments
Closed

Logging Rate Limits - Allow operators to better control log production #245

klakin-pivotal opened this issue Jun 7, 2022 · 6 comments
Labels
enhancement

Comments

@klakin-pivotal
Copy link
Contributor

Thanks for submitting an issue to capi-release. We are always trying to improve! To help us, please fill out the following template.

Issue

CF Operators are sometimes unhappy about the performance of the logging system in CF. We propose to add a system to permit operators more-fine-grained control over Application log handling.

We've work underway to add this system. This Github Issue serves to help track that work. We're not requesting that someone else address the issue; we believe we have it under control.

Context

The full context can be read here:
https://docs.google.com/document/d/1BEdtKHJ877Cn4HOfvAzIdMwoD0dpZuzRNBsmQ7c5_zM/edit#heading=h.sa8b0ujnd2tn
@klakin-pivotal
Copy link
Contributor Author

cc: @cloudfoundry/runtime

ctlong added a commit to cloudfoundry/cloud_controller_ng that referenced this issue Jun 7, 2022
@ctlong
Adds org quota for logs in bytes per second
4dfeeb5 
This commit updates the `/v3/organization_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182311424]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
ctlong added a commit to cloudfoundry/cloud_controller_ng that referenced this issue Jun 7, 2022
@ctlong @klakin-pivotal
Adds org quota for logs in bytes per second
63ee8a8 
This commit updates the `/v3/organization_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182311424]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
klakin-pivotal added a commit to cloudfoundry/cloud_controller_ng that referenced this issue Jun 7, 2022
@klakin-pivotal @ctlong
Adds space quota for logs in bytes per second
b3bf7de 
This commit updates the `/v3/space_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182353823]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
ctlong added a commit to cloudfoundry/cloud_controller_ng that referenced this issue Jul 5, 2022
@ctlong
Adds org quota for logs in bytes per second
08dda2e 
This commit updates the `/v3/organization_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182311424]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
ctlong pushed a commit to cloudfoundry/cloud_controller_ng that referenced this issue Jul 5, 2022
@klakin-pivotal @ctlong
Adds space quota for logs in bytes per second
0f07ed1 
This commit updates the `/v3/space_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182353823]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
@ctlong ctlong mentioned this issue Jul 18, 2022
Closed
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds org quota for logs in bytes per second
858605c 
This commit updates the `/v3/organization_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182311424]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@klakin-pivotal @ctlong
Adds space quota for logs in bytes per second
2d9c69e 
This commit updates the `/v3/space_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182353823]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds org quota for logs in bytes per second
3b5343e 
This commit updates the `/v3/organization_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182311424]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@klakin-pivotal @ctlong
Adds space quota for logs in bytes per second
f7911f6 
This commit updates the `/v3/space_quotas/` endpoints to allow
setting and retrieving of a new parameter (`log_limit_in_bytes_per_second`).
This will eventually permit the user to set log line production limits
in bytes per second, rather than lines per second.

Tracker Story ID: [#182353823]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
3c77607 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
d686475 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
c7b0ca5 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
cd826ca 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
7c7641f 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
3cd945f 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@acrmp @rroberts2222 @ctlong
Wrap log rate limit quota errors
9a4c849 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
97593ab 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
52c07ee 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@acrmp @rroberts2222 @ctlong
Wrap log rate limit quota errors
0a49f0d 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
d2f97e5 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
4b3fd83 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@acrmp @rroberts2222 @ctlong
Wrap log rate limit quota errors
0ee9144 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
a7f8e21 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
6150bc5 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@acrmp @rroberts2222 @ctlong
Wrap log rate limit quota errors
8d0ba00 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@ctlong
Adds log rate limit fields in bytes per second
a4de4c2 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
f09debe 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@acrmp @rroberts2222 @ctlong
Wrap log rate limit quota errors
bd32d0c 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
a6e3e01 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 3, 2022
@acrmp @rroberts2222 @ctlong
Wrap log rate limit quota errors
654d78f 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
ctlong added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 4, 2022
@ctlong
Adds log rate limit fields in bytes per second
88bda7c 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 4, 2022
@rroberts2222 @acrmp @ctlong
Handle -1 without a byte suffix
7d98525 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
ctlong pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 4, 2022
@acrmp @rroberts2222 @ctlong
Wrap log rate limit quota errors
e52378f 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
@acrmp acrmp mentioned this issue Aug 17, 2022
Merged
7 tasks
mkocher added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 19, 2022
@ctlong @mkocher @rroberts2222
Adds log rate limit fields in bytes per second
5d30f33 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
Co-authored-by: Matthew Kocher <[email protected]>
mkocher pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 19, 2022
@rroberts2222 @acrmp
Handle -1 without a byte suffix
0759aa0 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
mkocher pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 19, 2022
@acrmp @rroberts2222
Wrap log rate limit quota errors
0ac4c5d 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
mkocher added a commit to loggregator/cloud_controller_ng that referenced this issue Aug 19, 2022
@ctlong @mkocher @rroberts2222
Adds log rate limit fields in bytes per second
6f115cd 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
Co-authored-by: Matthew Kocher <[email protected]>
mkocher pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 19, 2022
@rroberts2222 @acrmp
Handle -1 without a byte suffix
20d07d8 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
mkocher pushed a commit to loggregator/cloud_controller_ng that referenced this issue Aug 19, 2022
@acrmp @rroberts2222
Wrap log rate limit quota errors
230e6a5 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
@ctlong ctlong mentioned this issue Sep 14, 2022
Merged
4 tasks
@sethboyles
Copy link
Member

I think we can close this now, now that cloudfoundry/cloud_controller_ng#2900 has been merged and released

@narcosis narcosis mentioned this issue Nov 7, 2022
Open
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this issue Dec 16, 2022
@ctlong @mkocher @will-gant
Adds log rate limit fields in bytes per second
b2668d2 
Updates the `/v3/organization_quotas/` and
`/v3/space_quotas/` endpoints to allow setting and retrieving of a new
parameter (`log_rate_limit_in_bytes_per_second`). This will eventually
permit the user to set log line production limits in bytes per second,
rather than lines per second.

Updates v3/processes and v3/tasks endpoints to support
`log_rate_limit_in_bytes_per_second`

An unlimited log rate limit is represented as -1

Tracker Story ID: [#182311424]
Tracker Story ID: [#182353823]
Tracker Story ID: [#182311433]
Tracker Story ID: [#182624538]
Tracker Story ID: [#182624530]
Github Issue: cloudfoundry/capi-release#245

Signed-off-by: Carson Long <[email protected]>
Signed-off-by: Kenneth Lakin <[email protected]>
Signed-off-by: Duane May <[email protected]>
Signed-off-by: Matthew Kocher <[email protected]>
Signed-off-by: Ben Fuller <[email protected]>
Signed-off-by: Seth Boyles <[email protected]>
Co-authored-by: Matthew Kocher <[email protected]>
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this issue Dec 16, 2022
@rroberts2222 @acrmp @will-gant
Handle -1 without a byte suffix
ae88575 
- We accept -1 without a byte suffix to mean unlimited
- We also return -1 in the rendered manifest

[#182624538](https://www.pivotaltracker.com/story/show/182624538)
Github Issue: cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
Co-authored-by: Andrew Crump <[email protected]>
will-gant pushed a commit to sap-contributions/cloud_controller_ng that referenced this issue Dec 16, 2022
@acrmp @rroberts2222 @will-gant
Wrap log rate limit quota errors
85a8cf8 
[#182311441](https://www.pivotaltracker.com/story/show/182311441)
cloudfoundry/capi-release#245

Co-authored-by: Rebecca Roberts <[email protected]>
@mogul
Copy link

mogul commented May 26, 2024

@klakin-pivotal can you please open access to the referenced Google Doc?

@klakin-pivotal
Copy link
Contributor Author

@mogul I cannot. As far as I can tell, that document was lost in one of the recent "Great Document Migrations".

@ctlong I assume you're still on the team that handles CAPI? If you are, do you have access to the document linked in this Issue? If you do, does it make sense to open that document up to folks outside the company? (I can't remember what the permissions originally were, so -to be safe- I'm assuming that they were restricted to just folks inside the company.)

@ctlong
Copy link
Member

ctlong commented May 28, 2024 •
edited
Loading

Unfortunately, I can't access that doc anymore either. Since this feature was completed though, much of the information in that doc should now be in public docs, e.g. https://docs.cloudfoundry.org/loggregator/app-log-rate-limits.html.

@mogul
Copy link

mogul commented May 29, 2024

Oh I hadn't seen that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mogul @sethboyles @cf-gitbot @ctlong @klakin-pivotal