Add Canary Deployment tests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Seth Boyles <[email protected]>
5 tasks
a-b
reviewed
Jul 31, 2024
| Expect(deploymentGUID).ToNot(BeEmpty()) | ||
| WaitUntilDeploymentReachesStatus(deploymentGUID, "FINALIZED", "DEPLOYED") | ||
| }) | ||
| }) | ||
|
|
||
| Describe("Canary deployments", func() { |
There was a problem hiding this comment.
thought(non-blocking): Should we have similar describe block for rolling deployments?
There was a problem hiding this comment.
Some of the existing tests are not specific for rolling, so we'd need to do some surgery to unpick the strategy specific tests. For now I think we can leave it and revisit it if we add a future strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Baras tests for canary deployments
Relates to cloudfoundry/cloud_controller_ng#3837