Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern uaa integration tests #2518

Merged
merged 3 commits into from
May 9, 2024
Merged

Modern uaa integration tests #2518

merged 3 commits into from
May 9, 2024

Conversation

selzoc
Copy link
Member

@selzoc selzoc commented May 8, 2024

What is this change about?

Use a modern UAA for integration tests

Please provide contextual information.

See commit

What tests have you run against this PR?

integration!

jpalermo and others added 2 commits May 8, 2024 14:38
Previous to this commit, the integration tests used a very very old
version of UAA (3.5.0) from an s3 bucket that needed Java 8.  Updates to
the integration Docker image that raised the JDK from 8->17 caused this
very old version to explode.

This commit represents a major refactoring of how UAA runs in the
integration specs.
* The UAA version now tracks the version in bosh-deployment
* There is only 1 UAA started, as opposed to 1 per spec process
* The UAA version is from uaa-release, and is templated accordingly

Java upgrade PRs:
* #2514
* #2515
* #2516

Co-authored-by: Aram Price <[email protected]>
Co-authored-by: Chris Selzo <[email protected]>
Co-authored-by: Chris Selzo <[email protected]>
@jpalermo jpalermo requested review from a team, bgandon and danielfor and removed request for a team May 9, 2024 15:08
@jpalermo
Copy link
Member

jpalermo commented May 9, 2024

@selzoc , I believe ci/dockerfiles/integration/install-uaa.rb is not used correct?

@selzoc
Copy link
Member Author

selzoc commented May 9, 2024

@selzoc , I believe ci/dockerfiles/integration/install-uaa.rb is not used correct?

Ah yes I believe we moved that functionality into src/bosh-dev/lib/bosh/dev/sandbox/services/uaa_service.rb.

Removed in ecce4ec

Copy link
Member

@cunnie cunnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you freshen UUA download URL every time. download a much-more-fresh version of UAA.

@cunnie cunnie merged commit 700143b into main May 9, 2024
4 checks passed
@cunnie cunnie deleted the modern-uaa-integration-tests branch May 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants