Retry in sync_dns_scheduler if migration not finished #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/164576311 The labels on this github issue will be updated when the story is started. |
|
✅ Hey beyhan! The commit authors and yourself have already signed the CLA. |
langered
force-pushed
the
ensure-migration-sync-dns-job
branch
from
1f9ca8b to
1d070b4
Compare
We have to ensure that the migration has finshed succesfully in the sync_dns_scheduler, before we can load the db Models. Otherwise the sync-dns job gets into an inconsistent state since the db is still being migrated or DB being upgraded. [#164325756](https://www.pivotaltracker.com/story/show/164325756) Co-authored-by: Sebastian Heid <[email protected]> Co-authored-by: Vladimir Videlov <[email protected]> Co-authored-by: Denis Langer <[email protected]>
langered
force-pushed
the
ensure-migration-sync-dns-job
branch
from
1d070b4 to
beb0061
Compare
Thread doesn't propagate exceptions but silently terminates if join is not called. Hence we only can use the ensure block to shut down the process or use Thread.abort_on_exception. [#164600574](https://www.pivotaltracker.com/story/show/164600574)
|
This change fixes this related issue where it director-sync-dns doesn't stop if an exception occurs. |
cf-gitbot
added
delivered
in progress
accepted
and removed
unscheduled
delivered
in progress
labels
selzoc
added a commit
that referenced
this pull request
May 8, 2024
Previous to this commit, the integration tests used a very very old version of UAA (3.5.0) from an s3 bucket that needed Java 8. Updates to the integration Docker image that raised the JDK from 8->17 caused this very old version to explode. This commit represents a major refactoring of how UAA runs in the integration specs. * The UAA version now tracks the version in bosh-deployment * There is only 1 UAA started, as opposed to 1 per spec process * The UAA version is from uaa-release, and is templated accordingly Java upgrade PRs: * #2154 * #2515 * #2516 Co-authored-by: Aram Price <[email protected]> Co-authored-by: Chris Selzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to ensure that the migration has finshed succesfully in the
sync_dns_scheduler, before we can load the db Models. Otherwise the
sync-dns job gets into an inconsistent state since the db is still being
migrated or DB being upgraded.
#164325756
Co-authored-by: Sebastian Heid [email protected]
Co-authored-by: Vladimir Videlov [email protected]
Co-authored-by: Denis Langer [email protected]
What is this change about?
Fix #2150
What tests have you run against this PR?
All unit and integration tests.
Also manually verified functionality by delaying the database migration by 30 seconds.
Does this PR introduce a breaking change?
No.
Tag your pair, your PM, and/or team!
@s4heid && @videlov && @langered