Fix broken offline environment create-env #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundler stopped picking up some cli flags and some env vars. there have
been warnings around this but we do not see them when the create-env
succeeds. It wasn't caught in CI since the CI environment is not
internetless. In that case bundler was still able to reach out to get the
gems that were already present locally (which it ignored because it
ignored the cli flags)
fixes:
```
Finished installing CPI (00:03:11)
Cleaning up rendered CPI jobs... Finished (00:00:00)
Error getting CPI info:
Executing external CPI command: '/home/tempest-web/.bosh/installations/22a68df8-5b95-4b3c-41a4-4f2dd8dab4e7/jobs/openstack_cpi/bin/cpi':
Running command: '/home/tempest-web/.bosh/installations/22a68df8-5b95-4b3c-41a4-4f2dd8dab4e7/jobs/openstack_cpi/bin/cpi', stdout: '', stderr: 'bundler: failed to load command: /home/tempest-web/.bosh/installations/22a68df8-5b95-4b3c-41a4-4f2dd8dab4e7/packages/bosh_openstack_cpi/bin/openstack_cpi (/home/tempest-web/.bosh/installations/22a68df8-5b95-4b3c-41a4-4f2dd8dab4e7/packages/bosh_openstack_cpi/bin/openstack_cpi)
/home/tempest-web/.bosh/installations/22a68df8-5b95-4b3c-41a4-4f2dd8dab4e7/packages/ruby-3.1.0-r0.81.0/lib/ruby/site_ruby/3.1.0/bundler/definition.rb:481:in `materialize': Could not find bosh_common-1.3262.24.0, bosh_cpi-2.5.0, excon-0.71.1, fog-openstack-1.1.0, httpclient-2.8.3, membrane-1.1.0, netaddr-2.0.5, logging-1.8.2, semi_semantic-1.2.0, fog-core-2.2.4, fog-json-1.2.0, ipaddress-0.8.3, little-plugger-1.1.4, multi_json-1.15.0, builder-3.2.4, formatador-0.3.0, mime-types-3.4.1, mime-types-data-3.2022.0105 in any of the sources (Bundler::GemNotFound)
from /home/tempest-web/.bosh/installations/22a68df8-5b95-4b3c-41a4-4f2dd8dab4e7/packages/ruby-3.1.0-r0.81.0/lib/ruby/site_ruby/3.1.0/bundler/definition.rb:190:in `specs'
from /home/tempest-web/.bosh/installations/22a68df8-5b95-4b3c-41a4-4f2dd8dab4e7/packages/ruby-3.1.0-r0.81.0/lib/ruby/site_ruby/3.1.0/bundler/definition.rb:238:in `specs_for'
```
Signed-off-by: jpalermo <[email protected]>
jpalermo
added a commit
that referenced
this pull request
Aug 1, 2022
Update the templates used to generate packaging scripts and update additional bundle flags Also update the cpi binary to use the new bundle flags Signed-off-by: Joseph Palermo <[email protected]> Co-authored-by: Joseph Palermo <[email protected]>
jpalermo
added a commit
that referenced
this pull request
Aug 1, 2022
We must cd into the package before setting the bundle config so the options persist into the src directory for when we run `bundle exec` later. Signed-off-by: Joseph Palermo <[email protected]> Co-authored-by: Joseph Palermo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundler stopped picking up some cli flags and some env vars. there have
been warnings around this but we do not see them when the create-env
succeeds. It wasn't caught in CI since the CI environment is not
internetless. In that case bundler was still able to reach out to get the
gems that were already present locally (which it ignored because it
ignored the cli flags)
fixes:
Signed-off-by: jpalermo [email protected]