Allow package cache dir to be overriden for create/delete env commands #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the bosh cli deploys a bosh director, it typically has a cache
under "$HOME/.bosh/installations/<GUID>/packages". This works fine if
you are compiling the CPI releases locally, as the same CPI release is
used both for creating the Director VM and for the Director VM to use to
create other VMs.
We want to be able to shorten the create-env time by using compiled CPI
releases. For Ruby-based CPIs, the location on the filesystem of their
packages when they are invoked matters. Since the CPI release is
compiled on stemcell, and is intended to be used on a Director VM, also
based on a stemcell, the Ruby-based CPIs NEED to be located in a
particular directory ("/var/vcap/packges") to function.
By allowing the bosh cli to use "/var/vcap/packages" as the package
cache directory, the create-env command can use the same compiled CPI as
the Director VM itself, with no modifications to the CPI.
[TPCF-9087]
Co-authored-by: Ming Xiao <[email protected]>
Co-authored-by: Nitin Ravindran <[email protected]>
aramprice
approved these changes
Aug 13, 2024
mingxiao
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bosh cli deploys a bosh director, it typically has a cache under "$HOME/.bosh/installations//packages". This works fine if you are compiling the CPI releases locally, as the same CPI release is used both for creating the Director VM and for the Director VM to use to create other VMs.
We want to be able to shorten the create-env time by using compiled CPI releases. For Ruby-based CPIs, the location on the filesystem of their packages when they are invoked matters. Since the CPI release is compiled on stemcell, and is intended to be used on a Director VM, also based on a stemcell, the Ruby-based CPIs NEED to be located in a particular directory ("/var/vcap/packges") to function.
By allowing the bosh cli to use "/var/vcap/packages" as the package cache directory, the create-env command can use the same compiled CPI as the Director VM itself, with no modifications to the CPI.