Unify upload release handling to always check if skippable #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2022 17:33
do the same as for git and http url releases and check if we need to actually upload before uploading. requires the sha1sum to be present in the release config.
https://www.pivotaltracker.com/story/show/180980049 To improve deployment times we looked into the upload release section for local tarballs. we skipped the existing checks for tarballs and opted to always reupload. This PR changes this behaviour The new behaviour will skip uploading releases IF the specified name and version are available within the director. --fix will this override this behaviour within the cli subcommand (unlike when triggered through manifests) this will only be triggered if the --name and --version flags are specified. ```shell ubuntu@lighttaupe-ops-manager:~$ bosh upload-release file:///var/tempest/releases/pxc-0.39.0-ubuntu-xenial-621.192.tgz Using environment '10.0.0.5' as client 'ops_manager' [-----------------------------------------------------------------] 100.00% 0s Task 125 Task 125 | 15:14:26 | Extracting release: Extracting release (00:00:00) Task 125 | 15:14:26 | Verifying manifest: Verifying manifest (00:00:00) Task 125 | 15:14:26 | Resolving package dependencies: Resolving package dependencies (00:00:00) Task 125 | 15:14:26 | Processing 8 existing jobs: Processing 8 existing jobs (00:00:00) Task 125 | 15:14:26 | Compiled Release has been created: pxc/0.39.0 (00:00:00) Task 125 Started Tue Jan 25 15:14:26 UTC 2022 Task 125 Finished Tue Jan 25 15:14:26 UTC 2022 Task 125 Duration 00:00:00 Task 125 done Succeeded ubuntu@lighttaupe-ops-manager:~$ bosh upload-release file:///var/tempest/releases/pxc-0.39.0-ubuntu-xenial-621.192.tgz --version 0.39.0 --name pxc Using environment '10.0.0.5' as client 'ops_manager' Release 'pxc/0.39.0' already exists. Succeeded ``` Signed-off-by: Long Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[180980049]
To improve deployment times we looked into the upload release
section for local tarballs. we skipped the existing checks (that were
used for http/git urls for tarballs and opted to always reupload.
This PR changes this behaviour
The new behaviour will skip uploading releases IF the specified
name and version are available within the director.
--fixwill still this override this behaviourwithin the cli subcommand this will only be triggered if the
--name and --version flags are specified.
we ran the full test suite.