Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config parameter to enable dualstack if needed #166

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

max-soe
Copy link
Contributor

@max-soe max-soe commented Aug 7, 2024

Based on #163, i added a config parameter to enable this feature.

@jpalermo
Copy link
Member

jpalermo commented Aug 7, 2024

Merging for now to fix pipelines. Keep in mind this now means there are no dual-stack tests being run in the cpi.

@jpalermo jpalermo merged commit 9d79e6e into cloudfoundry:master Aug 7, 2024
1 check passed
@jpalermo
Copy link
Member

jpalermo commented Aug 7, 2024

@max-soe , did you forget to add a new property to the job spec and then use that in cpi.json? You added a spec for it, but that fails because it doesn't exist.

@max-soe max-soe mentioned this pull request Aug 8, 2024
@max-soe
Copy link
Contributor Author

max-soe commented Aug 8, 2024

Hi @jpalermo,
yes i missed to commit the template changes:
https://github.com/cloudfoundry/bosh-aws-cpi-release/pull/167/files
Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants