Check for all types of errors when fetchingTasks to prevent panics (#95)

cloudfoundry · Apr 18, 2024 · a7ed0dc · a7ed0dc
1 parent 8758af9
commit a7ed0dc
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/db/sqldb/task_db.go b/db/sqldb/task_db.go
@@ -458,13 +458,18 @@ func (db *SQLDB) fetchTasks(ctx context.Context, logger lager.Logger, rows *sql.
 		var guid string
 
 		task, guid, err = db.fetchTaskInternal(logger, rows)
-		if err == models.ErrDeserialize {
-			invalidGuids = append(invalidGuids, guid)
+		if err != nil {
+			if err == models.ErrDeserialize {
+				invalidGuids = append(invalidGuids, guid)
+			}
+
 			if abortOnError {
 				break
 			}
+
 			continue
 		}
+
 		tasks = append(tasks, task)
 		validGuids = append(validGuids, task.TaskGuid)
 	}