This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Fix golangci issues on master branch #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardstudy
requested review from
manno and
viovanov
and removed request for
manno
mudler
reviewed
Aug 11, 2020
pkg/webhook/config.go
Outdated
| @@ -205,7 +205,10 @@ func (f *Config) CreateValidationWebhookServerConfig(ctx context.Context, webhoo | |||
| } | |||
| } | |||
| ctxlog.Debugf(ctx, "Creating validation webhook config '%s'", config.Name) | |||
| f.client.Delete(ctx, config) | |||
| err := f.client.Delete(ctx, config) | |||
| if err != nil && !apierrors.IsNotFound(err) { | |||
There was a problem hiding this comment.
Suggested change
| if err != nil && !apierrors.IsNotFound(err) { | |
| if err := f.client.Delete(ctx, config); err != nil && !apierrors.IsNotFound(err) { |
mudler
reviewed
Aug 11, 2020
pkg/webhook/config.go
Outdated
| @@ -251,7 +254,10 @@ func (f *Config) CreateMutationWebhookServerConfig(ctx context.Context, webhooks | |||
| } | |||
|
|
|||
| ctxlog.Debugf(ctx, "Creating mutating webhook config '%s'", config.Name) | |||
| f.client.Delete(ctx, &config) | |||
| err := f.client.Delete(ctx, &config) | |||
| if err != nil && !apierrors.IsNotFound(err) { | |||
There was a problem hiding this comment.
Suggested change
| if err != nil && !apierrors.IsNotFound(err) { | |
| if err := f.client.Delete(ctx, &config); err != nil && !apierrors.IsNotFound(err) { |
mudler
reviewed
Aug 11, 2020
pkg/logger/logger.go
Outdated
| @@ -27,7 +27,10 @@ func newLogger(level string, options ...zap.Option) *zap.Logger { | |||
| } | |||
|
|
|||
| l := zap.DebugLevel | |||
| l.Set(level) | |||
| err := l.Set(level) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| if err := l.Set(level); err != nil { |
mudler
reviewed
Aug 11, 2020
pkg/ctxlog/events.go
Outdated
| @@ -112,7 +112,11 @@ func (ev Event) debugJSON(ctx context.Context, objectInfo interface{}) { | |||
|
|
|||
| // treat JSON data as a string map and extract message | |||
| var result map[string]string | |||
| json.Unmarshal([]byte(jsonData), &result) | |||
| err := json.Unmarshal([]byte(jsonData), &result) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| if err := json.Unmarshal([]byte(jsonData), &result); err != nil { |
manno
reviewed
Aug 11, 2020
manno
reviewed
Aug 11, 2020
pkg/crd/crd.go
Outdated
| @@ -68,7 +68,7 @@ func ApplyCRD(ctx context.Context, client extv1client.ApiextensionsV1beta1Interf | |||
| } | |||
|
|
|||
| // WaitForCRDReady blocks until the CRD is ready. | |||
| func WaitForCRDReady(ctx context.Context, client extv1client.ApiextensionsV1beta1Interface, crdName string) error { | |||
| func WaitForCRDReady(ctx context.Context, client extv1client.ApiextensionsV1beta1Interface, crdName string) error { // nolint:interfacer | |||
There was a problem hiding this comment.
Does anyone intend to use the output of interfacer? Maybe we drop that linter
There was a problem hiding this comment.
@manno I had same feeling.
BTW, interface is out of maintain: https://github.com/mvdan/interfacer
Deprecated: A tool that suggests interfaces is prone to bad suggestions, so its usefulness in real code is limited.
mudler
reviewed
Aug 13, 2020
| @@ -112,7 +112,10 @@ func (ev Event) debugJSON(ctx context.Context, objectInfo interface{}) { | |||
|
|
|||
| // treat JSON data as a string map and extract message | |||
| var result map[string]string | |||
| json.Unmarshal([]byte(jsonData), &result) | |||
| if err := json.Unmarshal([]byte(jsonData), &result); err != nil { | |||
| return | |||
There was a problem hiding this comment.
Maybe it would be helpful to print the error to debug if it fails?
There was a problem hiding this comment.
Maybe it was silent for a reason, but then a few lines done it does print a debug msg. So why not here, too.
manno
approved these changes
Aug 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A chore.
Added TODO about errchecking on BindFlag.