This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Move credsgen to quarks-utils #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
force-pushed
the
split-credsgen
branch
2 times, most recently
from
ca50514 to
93ab08f
Compare
In this way it's more easy to carry it over and re-use the same across all crontrollers.
viovanov
approved these changes
Aug 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this way it's more easy to carry it over and re-use the same logic across
all crontrollers.
It also removes the loop where quarks-utils depends on quarks-secrets. In this way quarks-utils can be used more safely.