Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

feat: Auto-adapt NOTES.txt to HA changes in underlying CF manifest. #1593

Merged
merged 1 commit into from
Nov 17, 2020
Merged

feat: Auto-adapt NOTES.txt to HA changes in underlying CF manifest. #1593

merged 1 commit into from
Nov 17, 2020

Conversation

andreas-kupries
Copy link
Contributor

Description

Used @jandubois ' proposal to read the HA cell count from the underlying CF manifest, replacing the hardwired 3.

Motivation and Context

See #1591 (comment)

How Has This Been Tested?

Local minikube.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has security implications.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@viccuad
Copy link
Member

viccuad commented Nov 17, 2020 •
edited
Loading

Closes #1556

@viccuad viccuad merged commit 89d3953 into master Nov 17, 2020
@viccuad viccuad deleted the ak-kubecf-1479-notes.txt-2 branch November 17, 2020 14:51
@viccuad viccuad mentioned this pull request Nov 17, 2020
Merged
7 tasks
@gaktive gaktive added this to the 2.7.0 milestone Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viccuad viccuad viccuad approved these changes

@jandubois jandubois Awaiting requested review from jandubois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andreas-kupries @viccuad @gaktive