This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
feat: use generic fog provider for external blobstore #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
jandubois/fog-blobstore
branch
2 times, most recently
from
November 3, 2020 03:06
97f832b
to
ec9342f
Compare
Requires cloudfoundry-incubator/quarks-operator#1220 to be able to store |
jandubois
force-pushed
the
jandubois/fog-blobstore
branch
2 times, most recently
from
November 3, 2020 20:20
9166918
to
0ad0df4
Compare
jandubois
force-pushed
the
jandubois/fog-blobstore
branch
from
November 3, 2020 23:43
0ad0df4
to
7ac4029
Compare
Example configurations for Azure, AWS, Google Cloud can be found commented out in chart/values.yaml.
jandubois
force-pushed
the
jandubois/fog-blobstore
branch
from
November 24, 2020 21:15
7ac4029
to
03f703c
Compare
mook-as
suggested changes
Nov 24, 2020
chart/assets/operations/instance_groups/singleton-blobstore.yaml
Outdated
Show resolved
Hide resolved
chart/values.yaml
Outdated
# Additional settings for e.g. MinIO | ||
# ---------------------------------- | ||
# aws_signature_version: '2' | ||
# endpoint: S3-ENDPOINT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# endpoint: S3-ENDPOINT | |
# endpoint: https://custom-s3-endpoint.example.com/ |
Or whatever the correct syntax is (to show what the correct syntax is).
mook-as
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
changelog
Issue must be present in the release notes.
suse-cap
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements 2 features:
The PR removes the old "s3" provider and replaces it with "fog" which provides a superset of capabilities. The JSON schema will make sure that attempts to use "s3" will get an error.
This PR supports the simple configurations from https://docs.cloudfoundry.org/deploying/common/cc-blobstore-config.html (specifying provider, keys, and bucket names), plus some extra settings for non-AWS versions of S3 compatible storage. Things like encryption or service accounts etc. are not implemented, as they all would require mapping for bits-service/eirini. Plain webdav is also not supported, except via the singleton-blobstore.
This PR has been tested with a recent local MinIO server, using both path style addressing (Diego) and vhost addressing (Eirini):
Fixes #1540