This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Update nozzle dependencies #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all documentation mention of HttpStart, HttpStop. It was suggested as a tile option but not noted as a valid choice for the job spec.
gomega.Equal uses deepequal to compare time values. The code we're checking goes from time.Time -> int64 -> time.Time. The time is 'equivalent' but the internals of the time struct are different. - Added one check of the time to ensure the expected conversion path converts (comparing directly with unix timestamp) - Updated matchers to use gstruct.MatchAllElements/MatchAllFields so we can Ignore() the EventTime. Also gives much better error messages.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we're on the latest and greatest of our upstream dependencies