This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Allow the user to send any event to Stackdriver Logging #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we decided where to send firehose events based on the event
type. This change allows the user to pass in which specific events they
want in Stackdriver Logging, Stackdriver Monitoring.
- replace the filter with the filterSink
- remove firehose.events in favor of events_to_stackdriver_{logging,
monitoring}
- allow the log_sink to take in ValueMetric, ContainerMetric,
CounterEvent
- update BOSH job/tile for new properties
related #99
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to specify which events go to Stackdriver Logging and which to Stackdriver Monitoring instead of deciding based on event type.
This may require some additional work to cull metrics that are sent to logging. It's not clear if this will be an issue or not.
Related #99