Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring sonarqube issues #355

Merged
merged 12 commits into from
Oct 18, 2023
Merged

Refactoring sonarqube issues #355

merged 12 commits into from
Oct 18, 2023

Conversation

sbylica-splunk
Copy link
Collaborator

PR fixes most of the issues raised by sonarqube

@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 5, 2023 12:17 — with GitHub Actions Inactive
@VihasMakwana
Copy link
Collaborator

LGTM!
Will approve it once we get pipeline green and our PCF env running.

@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 6, 2023 14:12 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 6, 2023 16:17 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 06:56 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 07:50 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 08:03 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 08:13 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 08:19 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 08:34 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 08:39 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 09:04 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 09:59 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 10:37 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 13:26 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 17, 2023 13:31 — with GitHub Actions Inactive
@sbylica-splunk sbylica-splunk temporarily deployed to workflow-approval October 18, 2023 10:40 — with GitHub Actions Inactive
@sbylica-splunk
Copy link
Collaborator Author

LGTM! Will approve it once we get pipeline green and our PCF env running.

Pipeline is working and we finished our 1.3.0 merge, so I think this one is good to go :)

@sbylica-splunk sbylica-splunk merged commit ac71fe3 into develop Oct 18, 2023
sbylica-splunk added a commit that referenced this pull request Mar 29, 2024
@sbylica-splunk @VihasMakwana @metskem
Release 1.3.1 (#364)
767d1f6 
* Refactoring sonarqube issues (#355)
* Refactoring various functions to lower complexity
* Set "keepalive timeout", closing the splunk connection every 5 second - with configuration (#354)
* Keepalive timeout config (#361)
* Updated dependencies (#363)
* Version bump (#365)
* Edge processor configuration
* Upgrade to golang 1.20 and upgrade compatible dependencies

---------

Co-authored-by: VihasMakwana <[email protected]>
Co-authored-by: Vihas Splunk <[email protected]>
Co-authored-by: Harry Metske <[email protected]>
@sbylica-splunk sbylica-splunk mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@mbukowski-splunk mbukowski-splunk mbukowski-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbylica-splunk @VihasMakwana @mbukowski-splunk