Updated cache.GetApp logic to retrieve app info from boltdb database as well #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashyap-splunk
approved these changes
Sep 23, 2021
luckyj5
reviewed
Sep 28, 2021
| // Check if the app is available in boltdb cache | ||
| dbApp, _ := c.getAppFromDatabase(appGuid) | ||
| if dbApp != nil { | ||
| c.config.Logger.Debug(fmt.Sprint("Using old app info for cf_app_id ", appGuid)) |
There was a problem hiding this comment.
Debug in the nozzle is sending everything to stdout, shall we update the whole debug logic or handle this differently?
There was a problem hiding this comment.
If we enable the DEBUG mode, then the nozzle will dump all the event(events coming from remote and nozzle's log) to stdout. Otherwise it'll send it to the splunk.
Here, we are not enabling the DEBUG mode, but logging the message at debug level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did following changes: