Use Go modules instead of glide #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since go 1.11 has been out for a few months, it's reasonable to convert to using modules from `glide`.
|
(Just wanted to say that as someone who relies on this project for our CF foundations I'm glad to see active contributions to it 👍 thanks) |
|
Thanks for this submission @jghiloni and the others over the last few weeks. The team will look to incorporate these changes with the next release of the nozzle. Which at this stage is not scheduled, however with all the quality PRs that have come in, ill try and rectify that from our side. |
|
This got covered by another PR, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since go 1.11 has been out for a few months, it's reasonable to
convert to using modules from
glide.