feat(whoami): return accounts and account ids on whoami #983
Conversation
ashleygwilliams
force-pushed
the
existential-crisis
branch
3 times, most recently
from
5a1db3f to
bec7cb7
Compare
ashleygwilliams
changed the title
ashleygwilliams
added
status - needs review
and removed
status - work in progress
labels
src/commands/whoami/mod.rs
Outdated
| match user { | ||
| GlobalUser::TokenAuth { .. } => { |
There was a problem hiding this comment.
nit: can we use if let syntax here instead of match
if let GlobalUser::TokenAuth { .. } = user {
There was a problem hiding this comment.
i think the match is more appropriate, fwiw.
There was a problem hiding this comment.
it's only matching on one thing, i think generally if let fits that model better, it doesn't need an else and would eliminate the _ => ()
There was a problem hiding this comment.
can you say more about why you want if let?
There was a problem hiding this comment.
(there's no assignment here so i am less inclined)
ashleygwilliams
force-pushed
the
existential-crisis
branch
from
1be15c2 to
88cbd20
Compare
ashleygwilliams
added
status - work in progress
and removed
status - needs review
labels
ashleygwilliams
changed the title
ashleygwilliams
force-pushed
the
existential-crisis
branch
from
48750d5 to
5deebd1
Compare
ashleygwilliams
requested review from
ashleymichal and
EverlastingBugstopper
ashleygwilliams
added
status - needs review
and removed
status - work in progress
labels
ashleygwilliams
changed the title
|
|
||
| if let GlobalUser::TokenAuth { api_token: _ } = user { | ||
| if accounts.is_empty() { | ||
| println!("Your token is missing the 'Account Settings: Read' permission.\n\nPlease generate and auth with a new token that has these perms to be able to list your accounts.\n"); |
There was a problem hiding this comment.
accessibility nit: auth -> authenticate, perms -> permissions
There was a problem hiding this comment.
also may be worth linking to the api token page if possible https://dash.cloudflare.com/profile/api-tokens
ashleygwilliams
force-pushed
the
existential-crisis
branch
from
0716475 to
8dca5ad
Compare
ashleygwilliams
force-pushed
the
existential-crisis
branch
from
8dca5ad to
5fda862
Compare
| ); | ||
| message::info(&msg); | ||
| println!("\n{} You are logged in with {}.\n", emoji::WAVING, auth,); |
There was a problem hiding this comment.
why not use message? it's fine but i've been seeing this a lot lately, maybe our message module is not serving us well.
There was a problem hiding this comment.
ur not wrong. as said in air- the table would be offset if i used messaged because it would print INFO.
fixes #630