This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
add --format option, including default json and new pretty
#1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it may make sense to have this just be a --pretty flag, but if we decide we want to add more formats in the future (like forwarding raw devtools protocol stuff) then it's better to have the --format flag. Plus, we can introduce a warning like "the default is set to json but make sure to be explicit in case we change it"
caass
changed the title
--format option, including default json and new pretty--format option, including default json and new pretty
xortive
reviewed
Apr 14, 2021
Electroid
approved these changes
Apr 15, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may make sense to have this just be a --pretty flag, but if we decide we want to add more formats in the future (like forwarding raw devtools protocol stuff) then it's better to have the --format flag. Plus, we can introduce a warning like "the default is set to json but make sure to be explicit in case we change it"
Example of using
--format prettyhere:pretty.mp4