Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Pin dependency version for wasmpack and cargo-generate #1358

Merged
merged 6 commits into from
Jun 3, 2020

Conversation

jspspike
Copy link
Contributor

@jspspike jspspike commented Jun 2, 2020

This PR would make it so that wasmpack and cargo-generate have a fixed version set in src/install/dependencies.rs. It would pull a new version if there the package is not installed, the package has a different major version, or the package is older than the fixed target version.

Resolves #1240?

@jspspike jspspike requested a review from a team June 2, 2020 21:02
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - i just have one nit. could you change wasmpack to wasm_pack and WASMPACK to WASM_PACK

@EverlastingBugstopper EverlastingBugstopper merged commit 1dddcfd into master Jun 3, 2020
@jspspike jspspike deleted the josh/pin-dependency-version branch June 3, 2020 21:57
@ispivey ispivey added this to the 1.10.0 milestone Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only check for updating installed tools once every 24 hours
3 participants