This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
dont install wasm-pack for webpack type projects #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoo! 🎉 |
ashleymichal
approved these changes
Jun 2, 2020
|
This was initally made to simplify using rustwasm with webpack, it's a breacking change but since nobody complained (as far as I know) I guess nobody uses it. I still think we should install it from users because it's simpler. To avoid installing it for every webpack project, we can detect in wranglerjs if the webpack configuration uses the wasm-pack plugin |
|
@xtuc - didn't we make wasm-pack-plugin do the installation for you instead? I dont think that logic belongs in wrangler |
|
As far as I can remember wasm-pack plugin used to do the installation before we introduced it in wrangler and I'm unsure why we needed to. |
|
🤷 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #745
if folks want to use wasm-pack-plugin or some other tool, they should install and manage the necessary dependencies to do so. wrangler should only vendor what we know we need for the default use cases.
also we claimed to fix this in the 1.7.0 changelog and didn't actually do it