This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 335
[dev] reconnect socket after bad protocol message #1276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feb5c74
to
81d3106
Compare
81d3106
to
37686a4
Compare
getting a pretty opaque compiler error that i'm not sure how to resolve..
i want an async fn that i can and if an error occurs in either of the futures i've spawned (keep_alive messages and printing incoming socket messages) i want to kill the futures i've spawned and start my |
a6652a3
to
0394c28
Compare
0394c28
to
a25e46e
Compare
0bee503
to
d812db2
Compare
@ObsidianMinor thanks so much for the review 😄 |
ashleymichal
approved these changes
May 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1241
after a while, the preview service disconnects the websocket, even if you're being a good citizen and sending keep alive heartbeat messages every now and then. for shame! after merging this if your dev session gets disconnected from the websocket we'll issue a reconnect. :) :) :)